add support for launcher #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
now that we have flux executors within workflow managers, launching from a single job (e.g., in the docker container) is likely not going to work. We introduce here the idea of a launcher, or a known command to run on the server, e.g., "nextflow" that is able to launch flux jobs that are equivalently owned by the instance. Currently the one issue with this approach is the launcher writing to output file instead of stdout/stderr, but I have an issue open to figure out how to handle this. This PR will also fix a current set of bugs with parsing the checkbox (boolean) form fields - the name attribute was in the wrong spot, doh. Signed-off-by: vsoch <vsoch@users.noreply.github.com>
Signed-off-by: vsoch <vsoch@users.noreply.github.com>
Signed-off-by: vsoch <vsoch@users.noreply.github.com>
Signed-off-by: vsoch <vsoch@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
now that we have flux executors within workflow managers, launching from a single job (e.g., in the docker container) is likely not going to work. We introduce here the idea of a launcher, or a known command to run on the server, e.g., "nextflow" that is able to launch flux jobs that are equivalently owned by the instance. Currently the one issue with this approach is the launcher writing to
output file instead of stdout/stderr, but I have an issue open to figure out how to handle this.
This PR will also fix a current set of bugs with parsing the checkbox (boolean) form fields - the name attribute was in the wrong spot, doh.
Signed-off-by: vsoch vsoch@users.noreply.github.com