build: don't look for things we don't use #1086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: the build system looks for flux-core's libpmi but it is unused. Drop it from FindFluxCore.cmake.
Problem: the build system looks for libczmq but doesnt't use it. This was dropped from flux-core so we really don't want to require it for no reason. Drop from CMakeLists.txt. Fixes flux-framework#1085
Problem: the sphinx build emits warnings about missing workflow-examples. loading intersphinx inventory from https://flux-framework.readthedocs.io/projects/flux-workflow-examples/en/latest/objects.inv... WARNING: failed to reach any of the inventories with the following issues: intersphinx inventory 'https://flux-framework.readthedocs.io/projects/flux-workflow-examples/en/latest/objects.inv' not fetchable due to <class 'requests.exceptions.HTTPError'>: 404 Client Error: Not Found for url: https://flux-framework.readthedocs.io/projects/flux-workflow-examples/en/latest/objects.inv But that readthedocs project was deleted. Drop the reference from conf.py.
trws
force-pushed
the
drop_useless_things
branch
from
356e8d2 to
92ecfcf
Compare
Codecov Report
@@ Coverage Diff @@
## master #1086 +/- ##
========================================
- Coverage 71.7% 71.7% -0.1%
========================================
Files 89 89
Lines 11665 11665
========================================
- Hits 8374 8371 -3
- Misses 3291 3294 +3 |
garlick
added
the
merge-when-passing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This drops support from the build system for finding flux-core's libpmi.so and libczmq.so, neither of which are used by the scheduler.
Also, drop the deprecated workflow-examples readthedocs repo from the sphinx config.