build: reduce rebuilds, don't install dev tools #1090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trws
force-pushed
the
cmake-reduce-rebuilds
branch
from
40d0048 to
aaf5cb0
Compare
|
Since everything passed (before the rebase), I'm happy with this pending an accept review from anyone. Please add MWP for me if it's good since I'm about to head to bed and it will add about a day otherwise. |
grondo
changed the title
grondo
approved these changes
Sep 29, 2023
trws
added
the
merge-when-passing
Problem: any time cmake was rerun, it would rebuild *EVERYTHING* Solution: instead of unconditionally writing out the config.h every time (what I get for using the auto-generated config for that) use the proper `configure_file` command to generate it from a template.
Problem: docs were being rebuilt every build, regardless of changes Solution: split add_custom_target into command and target to properly track inputs and outputs
Removes the install of grug2dot and resource-query. They are still built, but no longer placed into an installation.
Ensure we only add REQUIRED to the check for sphinx when the ENABLE_DOCS option is "On" rather than "Try".
trws
force-pushed
the
cmake-reduce-rebuilds
branch
from
aaf5cb0 to
7ff8a93
Compare
Codecov Report
@@ Coverage Diff @@
## master #1090 +/- ##
======================================
Coverage 71.7% 71.7%
======================================
Files 89 89
Lines 11665 11665
======================================
Hits 8371 8371
Misses 3294 3294 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1078
Fixes #1089
Avoids rebuilds of docs, and global rebuilds on tweaks to CMakeLists.txt files as discussed in #1082.