Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

matrix: add el8 tag and make it test-install #1311

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

trws
Copy link
Member

@trws trws commented Oct 31, 2024

problem: we're not hooking up to the el8 container from core properly

solution: tag the container after the test, and match the core container with test-install

This is meant to match with #flux-core/6401 and ensure we propagate the el8 container all the way through.

@trws trws requested review from grondo and milroy October 31, 2024 01:24
problem: we're not hooking up to the el8 container from core properly

solution: tag the container after the test, and match the core container
with test-install
Copy link
Member

@milroy milroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good; thanks for the quick PR.

@trws trws added merge-when-passing mergify.io - merge PR automatically once CI passes and removed merge-when-passing mergify.io - merge PR automatically once CI passes labels Oct 31, 2024
@mergify mergify bot merged commit 93589f5 into flux-framework:master Oct 31, 2024
21 checks passed
Copy link

codecov bot commented Oct 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.3%. Comparing base (996f999) to head (ba57560).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #1311    +/-   ##
=======================================
  Coverage    75.3%   75.3%            
=======================================
  Files         111     111            
  Lines       15300   15979   +679     
=======================================
+ Hits        11531   12048   +517     
- Misses       3769    3931   +162     

see 70 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge-when-passing mergify.io - merge PR automatically once CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants