Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simulator: Update for recent kvs API changes #234

Merged
merged 1 commit into from
Feb 22, 2017

Conversation

chu11
Copy link
Member

@chu11 chu11 commented Feb 18, 2017

Add flags argument to kvs_commit() calls to work with new KVS API.

To be merged after flux-core PR #982 is merged.

Add flags argument to kvs_commit() calls to work with new KVS
API.
@garlick
Copy link
Member

garlick commented Feb 21, 2017

I just merged flux-framework/flux-core#982 and restarted travis on this PR.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 72.679% when pulling 682734f on chu11:kvsabichange into 8f43078 on flux-framework:master.

@codecov-io
Copy link

codecov-io commented Feb 21, 2017

Codecov Report

Merging #234 into master will increase coverage by 0.05%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #234      +/-   ##
==========================================
+ Coverage      55%   55.05%   +0.05%     
==========================================
  Files          25       25              
  Lines        5178     5184       +6     
  Branches     1167     1168       +1     
==========================================
+ Hits         2848     2854       +6     
  Misses       1626     1626              
  Partials      704      704
Impacted Files Coverage Δ
simulator/simulator.c 62.5% <ø> (ø)
simulator/sim_execsrv.c 65.3% <100%> (ø)
src/common/libutil/shortjansson.h 65.15% <ø> (+3.48%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f43078...682734f. Read the comment docs.

@dongahn
Copy link
Member

dongahn commented Feb 22, 2017

LGTM. Merging.

@dongahn dongahn merged commit 7b95852 into flux-framework:master Feb 22, 2017
@grondo grondo mentioned this pull request Aug 23, 2017
@chu11 chu11 deleted the kvsabichange branch July 2, 2021 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants