resrc: Add resource API context support #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add get_resrc_reqst and move the logic to fill resrc_reqst to this function. Enhance readability of schedule_job which has grown somewhat large. More importantly, being ready to encode resource aggregate info without having to modify the main schedule_job function.
Codecov Report
@@ Coverage Diff @@
## master #236 +/- ##
=========================================
+ Coverage 55.05% 55.3% +0.24%
=========================================
Files 25 25
Lines 5184 5204 +20
Branches 1168 1181 +13
=========================================
+ Hits 2854 2878 +24
+ Misses 1626 1616 -10
- Partials 704 710 +6
Continue to review full report at Codecov.
|
lipari
reviewed
Mar 1, 2017
resrc/test/tresrc.c
Outdated
| ok (((resrc = resrc_create_cluster ("cluster")) != 0), | ||
| "cluster resource creation succeeded"); | ||
| ok ((resrc_generate_hwloc_resources (resrc, topology, NULL, NULL) != 0), | ||
| /* Generate teh hardware hiearchy of resources using hwloc reader */ |
|
@dongahn, looks great! I'm ready to merge once typos are fixed. There are 4 misspelled "hiearchy" in tresrc.c. |
|
Got it. Will work on this and push. |
Add resource API context support to streamline our future scheduling
improvements which includes upcoming scheduler-driven aggregate updates work.
Add resrc_api.h where resrc_api_init () and resrc_api_fini () are declared.
resrc_api_init () creates and initializes an instance of the resource APIs
which are implemented across resrc, resrc_tree, resrc_flow, and resrc_reqst.
Once the context is returned from resrc_api_init (), the caller must pass
it as an opaque handle to certain API calls in the resrc and friends.
This allows these APIs to act on the specific API instance.
Define struct resrc_api_ctx in resrc_api_internal.h which should only
be included om resource API internal implementation files
Over time, resrc_api will add some other API-level functions that will
allow an API instance to be specialized.
Add, delete and revise some API calls and internals as part of this commit, as well:
- Add query routines into resrc tree/flow APIs to allow users to fetch
the roots of constructed graphs using the resource API context;
- Clean up rsreader APIs and sched internals a bit using these new routines
|
Ok. Ready. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add resource API context support + some minor cleanup