Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sched/simulator: Add missing sim_state = NULL assignments #240

Merged
merged 1 commit into from
Mar 22, 2017

Conversation

lipari
Copy link
Contributor

@lipari lipari commented Mar 22, 2017

Corrects a problem that was revealed with
#238

@dongahn
Copy link
Member

dongahn commented Mar 22, 2017

LGTM. I will merge this when Travis turns green.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.5%) to 73.434% when pulling c186435 on lipari:sim_state_null into ca349c9 on flux-framework:master.

@codecov-io
Copy link

codecov-io commented Mar 22, 2017

Codecov Report

Merging #240 into master will increase coverage by 0.49%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master    #240      +/-   ##
=========================================
+ Coverage    55.2%   55.7%   +0.49%     
=========================================
  Files          25      25              
  Lines        5184    5186       +2     
  Branches     1179    1179              
=========================================
+ Hits         2862    2889      +27     
+ Misses       1615    1588      -27     
- Partials      707     709       +2
Impacted Files Coverage Δ
sched/sched.c 57.14% <100%> (+1.03%) ⬆️
simulator/sim_execsrv.c 70.05% <100%> (+4.74%) ⬆️
simulator/submitsrv.c 69.93% <0%> (+1.22%) ⬆️
simulator/simsrv.c 54.18% <0%> (+2.95%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca349c9...c186435. Read the comment docs.

@dongahn dongahn merged commit 6d49692 into flux-framework:master Mar 22, 2017
@lipari lipari deleted the sim_state_null branch March 22, 2017 16:55
@grondo grondo mentioned this pull request Aug 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants