Fix simulator and re-enable sim integration tests #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rather than using `flux_msg_create` to create the message, followed by `flux_msg_set_topic`, etc, just use `flux_request_encode`. This reduces the LOC and enables message routing for the RPC.
a value within the zhash, rather than the zhash object itself, was being passed as an argument to `zhash_cursor`, causing a segfault. Simulator integration tests work now.
If there are no jobs left to be submitted and the submit module is triggered anyways, then reply to the `sim` module with `next_time` set to -1
Rather than using multiple while loops, reduce down to a single for loop. The refactor also removes the need for calling `zhash_keys`.
IMO, pulling the complex conditional logic out into inline functions greatly improves the readability of the code
|
Nice job @SteVwonder, thanks for running this down and sorry we broke the world. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problems with the simulator were unearthed in #246 since this was the first PR to sched in several months. We temporarily disabled the simulator integration tests until the problems were resolved. This PR fixes those problems and re-enables the simulator integration tests.
I also refactored a few functions in the simulator to simplify their main loops and logging (I can put these changes into a separate PR, if desired)
To avoid this situation in the future, we have setup a nightly cron job on Travis CI for flux-sched.
Fixes #249