Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sim: track changes in flux-core to jansson functions #255

Merged
merged 1 commit into from
Jul 19, 2017

Conversation

SteVwonder
Copy link
Member

Tracks changes in flux-framework/flux-core#1104

Old New
flux_kvs_lookup_getf() flux_kvs_lookup_get_unpack()
flux_msg_set_jsonf() flux_msg_pack()
flux_msg_vset_jsonf() flux_msg_vpack()
flux_msg_get_jsonf() flux_msg_unpack()
flux_msg_vget_jsonf() flux_msg_vunpack()
flux_rpcf() flux_rpc_pack()
flux_rpc_getf() flux_rpc_get_unpack()
flux_event_decodef() flux_event_unpack()
flux_event_encodef() flux_event_pack()
flux_request_decodef() flux_request_unpack()
flux_respondf() flux_respond_pack()

Fixes #254

@SteVwonder SteVwonder requested a review from garlick July 19, 2017 21:17
@SteVwonder
Copy link
Member Author

SteVwonder commented Jul 19, 2017

I am getting runtime error messages from the simulator, but the tests pass.
Example error message:

2017-07-19T21:04:14.879698Z sim_exec.err[0]: pull_job_from_kvs: failed to get starting_time in lwj.0.0.1: No such file or directory

I'm tracking down those errors now. We can merge this PR and I'll submit another PR for those errors, or we can wait until I fix those errors. I'm fine with either.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 73.735% when pulling aa511ed on SteVwonder:track-core-changes into 9f77522 on flux-framework:master.

@codecov-io
Copy link

codecov-io commented Jul 19, 2017

Codecov Report

Merging #255 into master will not change coverage.
The diff coverage is 90.9%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #255   +/-   ##
======================================
  Coverage    69.9%   69.9%           
======================================
  Files          25      25           
  Lines        5286    5286           
======================================
  Hits         3695    3695           
  Misses       1591    1591
Impacted Files Coverage Δ
simulator/simsrv.c 72.9% <100%> (ø) ⬆️
simulator/submitsrv.c 84.09% <100%> (ø) ⬆️
simulator/simulator.c 83.76% <85.71%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f77522...aa511ed. Read the comment docs.

@garlick
Copy link
Member

garlick commented Jul 19, 2017

Looks great @SteVwonder. I'll go ahead and merge since travis passed and this is just name changes.

@garlick garlick merged commit a30e2f0 into flux-framework:master Jul 19, 2017
@SteVwonder SteVwonder deleted the track-core-changes branch July 20, 2017 16:18
@grondo grondo mentioned this pull request Aug 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants