-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Helm chart rename #1264
Helm chart rename #1264
Conversation
Not fully ready for review yet. Will add reviewers when all tests etc are working. |
Hmm interesting that this change breaks all the tests with a go version syntax error. I'll look into what is going on. |
The tests starting to fail wasn't related to this specific branch, but would happen in all branches: kubernetes-sigs/controller-runtime#2720 Using the latest tag for pulling in versions in CI pipelines are in general bad practise. I've pinned the version of setup-envtest to solve the issue for now. Will create a seperate issue for this topic instead of going into to much detail here. |
Adds updates to crds from /config/crd/bases/infra.contrib.fluxcd.io_terraform
While renaming the chart i also updated the CRDs with the changes from config/crd/bases which should fix #1268 |
This should be ready for review, but i might have missed something that could have side effects without knowing. Especially when it comes to the CRDs. So any feedback would be appreciated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thank you @ilithanos 🥇
#1252 has no comments on this.
This should rename the helm chart to the new tofu-controller naming and ensure versions in values and labels are tagged with the rc.4 version of the tofu controller.
It should also change the CI to use the new naming convention for both chart and controller
Also fixes #1268 by updating the CRDs within the chart