Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm chart rename #1264

Merged
merged 6 commits into from
Mar 29, 2024
Merged

Helm chart rename #1264

merged 6 commits into from
Mar 29, 2024

Conversation

ilithanos
Copy link
Collaborator

@ilithanos ilithanos commented Mar 24, 2024

#1252 has no comments on this.

This should rename the helm chart to the new tofu-controller naming and ensure versions in values and labels are tagged with the rc.4 version of the tofu controller.

It should also change the CI to use the new naming convention for both chart and controller

Also fixes #1268 by updating the CRDs within the chart

@ilithanos ilithanos self-assigned this Mar 24, 2024
@ilithanos
Copy link
Collaborator Author

Not fully ready for review yet. Will add reviewers when all tests etc are working.

@ilithanos
Copy link
Collaborator Author

Hmm interesting that this change breaks all the tests with a go version syntax error. I'll look into what is going on.

@ilithanos
Copy link
Collaborator Author

The tests starting to fail wasn't related to this specific branch, but would happen in all branches:

kubernetes-sigs/controller-runtime#2720

Using the latest tag for pulling in versions in CI pipelines are in general bad practise. I've pinned the version of setup-envtest to solve the issue for now.

Will create a seperate issue for this topic instead of going into to much detail here.

Adds updates to crds from /config/crd/bases/infra.contrib.fluxcd.io_terraform
@ilithanos
Copy link
Collaborator Author

While renaming the chart i also updated the CRDs with the changes from config/crd/bases which should fix #1268

@ilithanos
Copy link
Collaborator Author

This should be ready for review, but i might have missed something that could have side effects without knowing.

Especially when it comes to the CRDs. So any feedback would be appreciated.

Copy link
Collaborator

@chanwit chanwit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thank you @ilithanos 🥇

@chanwit chanwit merged commit cf74388 into main Mar 29, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tfVarsFiles schema is missing from the Helm chart CRDs
2 participants