Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve docs #1275

Merged
merged 1 commit into from
Apr 10, 2024
Merged

Improve docs #1275

merged 1 commit into from
Apr 10, 2024

Conversation

vishu42
Copy link

@vishu42 vishu42 commented Apr 6, 2024

@vishu42 vishu42 marked this pull request as draft April 6, 2024 06:06
@vishu42 vishu42 marked this pull request as ready for review April 6, 2024 06:23
@vishu42
Copy link
Author

vishu42 commented Apr 6, 2024

@chanwit I have opened this PR to address issue #490

  • I don't think any change is required for 1st point, as the doc here is pretty clear on the behaviour of .spec.approvePlan :disable.
  • For the 2nd point I have made the required changes in the document.
  • For the 3rd point, the scope seems very broad as it questions documentation of each field in terraform spec. Also, the spec has been updated many times since the issue was originally reported which means many of the reporter's concerns might have already been resolved.

@vishu42
Copy link
Author

vishu42 commented Apr 10, 2024

@chanwit can you please take a look :)

chanwit
chanwit approved these changes Apr 10, 2024
View reviewed changes
Copy link
Collaborator

@chanwit chanwit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep, LGTM.
Thank you @vishu42

@chanwit chanwit merged commit 3dda31f into flux-iac:main Apr 10, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chanwit chanwit chanwit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vishu42 @chanwit @avish42