Add --no-cross-namespace-refs to tf-controller #677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bigkevmcd
reviewed
Jun 20, 2023
squaremo
force-pushed
the
no-cross-ns-controller
branch
3 times, most recently
from
89050a7
to
20ecd27
Compare
bigkevmcd
previously approved these changes
Jun 21, 2023
The Flux convention is to use the flag --no-cross-reference-refs (as encoded in github.com/fluxcd/pkg/acl) to deny cross-namespace references, thereby closing a potential security hole. This commit adds support for the flag to the controller, and a test that it does indeed ban cross-namespace refs. Signed-off-by: Michael Bridgen <michael.bridgen@weave.works>
squaremo
force-pushed
the
no-cross-ns-controller
branch
from
20ecd27
to
91d524b
Compare
bigkevmcd
approved these changes
Jun 21, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Flux convention is to use the flag --no-cross-reference-refs (as encoded in github.com/fluxcd/pkg/acl) to deny cross-namespace references, thereby closing a potential security hole.
This commit adds support for the flag to the controller, and a test that it does indeed ban cross-namespace refs.