Skip to content

Commit

Permalink
Merge pull request #1044 from Misteur-Z/external-dns-docs
Browse files Browse the repository at this point in the history
Add warning in docs about ExternalDNS + Istio configuration
  • Loading branch information
stefanprodan authored Nov 9, 2021
2 parents 6b11e97 + 944cc8e commit 9c7db58
Show file tree
Hide file tree
Showing 2 changed files with 40 additions and 1 deletion.
39 changes: 39 additions & 0 deletions docs/gitbook/faq.md
Original file line number Diff line number Diff line change
Expand Up @@ -858,3 +858,42 @@ spec:
mtls:
mode: DISABLE
```

## ExternalDNS

### Can I use annotations?

Flagger propagates annotations (and labels) to all the generated apex,
primary and canary objects. This allows using external-dns annotations.

You can configure Flagger to set annotations with:

```yaml
spec:
service:
apex:
annotations:
external-dns.alpha.kubernetes.io/hostname: "mydomain.com"
primary:
annotations:
external-dns.alpha.kubernetes.io/hostname: "primary.mydomain.com"
canary:
annotations:
external-dns.alpha.kubernetes.io/hostname: "canary.mydomain.com"
```

### Multiple sources and Istio

**/!\\** The apex annotations are added to both the generated Kubernetes Services and the generated Istio
VirtualServices objects. If you have configured external-dns to use both sources,
this will create conflicts!

```yaml
spec:
containers:
args:
- --source=service # choose only one
- --source=istio-virtualservice # of these two
```

[Checkout ExeternalDNS documentation](https://github.com/kubernetes-sigs/external-dns/blob/master/docs/tutorials/istio.md)
2 changes: 1 addition & 1 deletion docs/gitbook/usage/how-it-works.md
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,7 @@ spec:

Note that the `apex` annotations are added to both the generated Kubernetes Service and the
generated service mesh/ingress object. This allows using external-dns with Istio `VirtualServices`
and `TraefikServices`.
and `TraefikServices`. Beware of configuration conflicts [here](../faq.md#ExternalDNS).

Besides port mapping and metadata, the service specification can
contain URI match and rewrite rules, timeout and retry polices:
Expand Down

0 comments on commit 9c7db58

Please sign in to comment.