Skip to content

Commit

Permalink
Merge pull request #502 from weaveworks/fix-istio-examples
Browse files Browse the repository at this point in the history
docs: Update A/B testing docs for Istio 1.5
  • Loading branch information
stefanprodan authored Mar 16, 2020
2 parents ebfbe1b + bc4e0d6 commit e76a679
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion artifacts/examples/istio-abtest.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ spec:
regex: "^(.*?;)?(type=insider)(;.*)?$"
- headers:
user-agent:
regex: "(?=.*Safari)(?!.*Chrome).*$"
regex: ".*Firefox.*"
metrics:
- name: request-success-rate
thresholdRange:
Expand Down
8 changes: 4 additions & 4 deletions docs/gitbook/tutorials/istio-ab-testing.md
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ Deploy the load testing service to generate traffic during the canary analysis:
kubectl apply -k github.com/weaveworks/flagger//kustomize/tester
```

Create a canary custom resource \(replace example.com with your own domain\):
Create a canary custom resource (replace example.com with your own domain):

```yaml
apiVersion: flagger.app/v1beta1
Expand Down Expand Up @@ -112,7 +112,7 @@ spec:
match:
- headers:
user-agent:
regex: "^(?!.*Chrome).*Safari.*"
regex: ".*Firefox.*"
- headers:
cookie:
regex: "^(.*?;)?(type=insider)(;.*)?$"
Expand All @@ -133,15 +133,15 @@ spec:
webhooks:
- name: load-test
url: http://flagger-loadtester.test/
timeout: 5s
timeout: 15s
metadata:
cmd: "hey -z 1m -q 10 -c 2 -H 'Cookie: type=insider' http://podinfo.test:9898/"
```
**Note** that when using Istio 1.5 you have to replace the `request-duration`
with a [metric template](https://docs.flagger.app/dev/upgrade-guide#istio-telemetry-v2).

The above configuration will run an analysis for ten minutes targeting Safari users and those that have an insider cookie.
The above configuration will run an analysis for ten minutes targeting Firefox users and those that have an insider cookie.

Save the above resource as podinfo-abtest.yaml and then apply it:

Expand Down

0 comments on commit e76a679

Please sign in to comment.