Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alert severity WARN does not seem to work #1072

Closed
eugeneromero opened this issue Dec 7, 2021 · 4 comments · Fixed by #1105
Closed

Alert severity WARN does not seem to work #1072

eugeneromero opened this issue Dec 7, 2021 · 4 comments · Fixed by #1105
Labels
kind/bug Something isn't working

Comments

@eugeneromero
Copy link

eugeneromero commented Dec 7, 2021

Describe the bug

According to the documentation:

When the severity is set to warn, Flagger will alert when waiting on manual confirmation or if the analysis fails.

However, when we set the severity of our messages to warn, no messages are sent out (to Teams in our case). Error severity was not tested.

To Reproduce

  1. Create a canary-teams-webhook secret with a key address, containing a webhook for a Teams channel.
  2. Create a Canary Alert Provider:
apiVersion: flagger.app/v1beta1
kind: AlertProvider
metadata:
  name: failed-canaries-alert
spec:
  type: msteams
  secretRef:
    name: canary-teams-webhook
  1. Create a Canary with an analysis alert:
apiVersion: flagger.app/v1beta1
kind: Canary
spec:
[...]
  analysis:
    alerts:
      - name: "Failed canaries alert"
        severity: warn
        providerRef:
          name: failed-canaries-alert

Expected behavior

I would expect to see a message in Teams, when my canary fails. However, nothing is ever logged to Teams. I can see that the canary has failed, however:

$ kubectl get canary
NAME           STATUS   WEIGHT   LASTTRANSITIONTIME
dev-course     Failed   0        2021-12-02T16:03:00Z

If I only change the severity to info (no other changes), then I start to see messages for all canary activity:

image

Additional context

  • Flagger version: 1.14.0
  • Kubernetes version: 1.20.7
  • Service Mesh provider: Linkerd 2.11.1
  • Ingress provider: ingress-nginx 1.1.0
@eugeneromero
Copy link
Author

Bumping this, is there any new information about it?

@stefanprodan
Copy link
Member

Looks like a bug, I haven't got time to look into it. Can you confirm that setting the level to error works ok?

@eugeneromero
Copy link
Author

Apologies, I'd forgotten to reply here. We have now set a few of our services to error, I should have an answer for you in the next few days 👍

@eugeneromero
Copy link
Author

@stefanprodan, I can confirm that error level does indeed work as expected. So it seems to be only warn that does not output warnings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants