Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send warning and error alerts correctly #1105

Merged
merged 1 commit into from
Feb 9, 2022

Conversation

somtochiama
Copy link
Member

@somtochiama somtochiama commented Feb 8, 2022

This pull requests sends alerts for severity warn when waiting on manual confirmation AND when the analysis fails.
It sends alerts with severity error only when the analysis fails.

Closes #1072

Signed-off-by: Somtochi Onyekwere somtochionyekwere@gmail.com

Signed-off-by: Somtochi Onyekwere <somtochionyekwere@gmail.com>
@codecov-commenter
Copy link

Codecov Report

Merging #1105 (9796903) into main (7071d42) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1105   +/-   ##
=======================================
  Coverage   57.23%   57.23%           
=======================================
  Files          78       78           
  Lines        6342     6342           
=======================================
  Hits         3630     3630           
  Misses       2171     2171           
  Partials      541      541           
Impacted Files Coverage Δ
pkg/controller/events.go 52.89% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7071d42...9796903. Read the comment docs.

Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @somtochiama

@stefanprodan stefanprodan merged commit b7ba3ab into fluxcd:main Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Alert severity WARN does not seem to work
3 participants