Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

App Mesh request duration metric check #143

Closed
stefanprodan opened this issue Apr 12, 2019 · 0 comments · Fixed by #322
Closed

App Mesh request duration metric check #143

stefanprodan opened this issue Apr 12, 2019 · 0 comments · Fixed by #322
Labels
kind/enhancement Improvement request for an existing feature kind/upstream-blocked Depends on a missing upstream feature

Comments

@stefanprodan
Copy link
Member

Envoy 1.10.0 comes with Prometheus histogram metrics. This will allow Flagger to validate canary deployments on App Mesh based on request duration average (similar to istio_request_duration_seconds_bucket).

Depends on aws/aws-app-mesh-roadmap#54
@stefanprodan stefanprodan added kind/upstream-blocked Depends on a missing upstream feature kind/enhancement Improvement request for an existing feature labels Apr 12, 2019
@stefanprodan stefanprodan mentioned this issue Apr 12, 2019
Merged
stefanprodan added a commit that referenced this issue Oct 3, 2019
@stefanprodan
Add App Mesh request duration metric check to docs
74c1c2f 
Fix: #143 depend on App Mesh Envoy >1.11
@stefanprodan stefanprodan mentioned this issue Oct 3, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/enhancement Improvement request for an existing feature kind/upstream-blocked Depends on a missing upstream feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for acceptance testing when using App Mesh fluxcd/flagger
1 participant
@stefanprodan