Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend canary analysis with external checks #17

Closed
stefanprodan opened this issue Dec 22, 2018 · 0 comments
Closed

Extend canary analysis with external checks #17

stefanprodan opened this issue Dec 22, 2018 · 0 comments
Labels
kind/feature Feature request

Comments

@stefanprodan
Copy link
Member

stefanprodan commented Dec 22, 2018

The canary analysis could be extended with webhooks. Flagger would call a URL and determine from the response status code if the canary is failing or not.

CRD spec:

kind: Canary
metadata:
  name: podinfo
  namespace: prod
spec:
  canaryAnalysis:
    webhooks:
    - name: check1
      url: http://validator.prod.svc.cluster.local:9898/check
      timeout: 10s
      # arbitrary key-value pairs 
      metadata:
        key1: "value1"
        key2: "value2"

Webhook payload (HTTP POST JSON):

{
    "name": "podinfo",
    "namespace": "prod", 
    "metadata": {
        "key1":  "value1",
        "key2":  "value2"
    }
}

Response status codes:

  • 200-202 - advance canary by increasing the traffic weight
  • timeout or non-2xx - halt advancement and increment failed checks

On a non-2xx response include the the response body (if any) in the failed checks log & event.

@stefanprodan stefanprodan added the kind/feature Feature request label Dec 22, 2018
@stefanprodan stefanprodan changed the title Canary external checks validation webhook Extend canary analysis with external checks Dec 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Feature request
Projects
None yet
Development

No branches or pull requests

1 participant