Add external checks to canary analysis #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add required fields for deployment and hpa targets - make service port mandatory - add webhooks validation
- do a HTTP POST for each webhook registered in the canary analysis - increment the failed checks counter if a webhook returns a non-2xx status code and log the error and the response body if exists
Codecov Report
@@ Coverage Diff @@
## master #18 +/- ##
=========================================
+ Coverage 44.24% 50.95% +6.7%
=========================================
Files 6 7 +1
Lines 904 942 +38
=========================================
+ Hits 400 480 +80
+ Misses 449 381 -68
- Partials 55 81 +26
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds webhook capabilities to the canary validation process. The canary analysis can be extend with integration tests, load tests or any kind of custom validation logic.
Fix #17