Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restart analysis if revision changes during validation #30

Closed
stefanprodan opened this issue Jan 17, 2019 · 0 comments
Closed

Restart analysis if revision changes during validation #30

stefanprodan opened this issue Jan 17, 2019 · 0 comments
Labels
kind/enhancement Improvement request for an existing feature

Comments

@stefanprodan
Copy link
Member

Currently if there is an canary analysis underway and a new revision is applied on the cluster, Flagger will wait for the new revision to be rolled out and will resume the analysis. This could lead to an erroneous promotion since the new revision will not be fully validated. Instead of resuming the analysis Flagger should reset the validation process (set the failed checks and canary weight to zero) and start a fresh analysis.
@stefanprodan stefanprodan changed the title Restart promotion process if revision changes during analysis Restart validation if revision changes during analysis Jan 17, 2019
@stefanprodan stefanprodan added the kind/enhancement Improvement request for an existing feature label Jan 17, 2019
@stefanprodan stefanprodan mentioned this issue Jan 17, 2019
Merged
@stefanprodan stefanprodan changed the title Restart validation if revision changes during analysis Restart analysis if revision changes during validation Jan 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/enhancement Improvement request for an existing feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@stefanprodan