Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restart analysis if revision changes during validation #31

Merged
merged 3 commits into from
Jan 18, 2019
Merged

Conversation

stefanprodan
Copy link
Member

@stefanprodan stefanprodan commented Jan 17, 2019

Currently if there is an canary analysis underway and a new revision is applied on the cluster, Flagger will wait for the new revision to be rolled out and will resume the analysis. This could lead to an erroneous promotion since the new revision will not be fully validated. Instead of resuming the analysis Flagger should reset the validation process (set the failed checks and canary weight to zero) and start a fresh analysis.

Fix #30

@codecov-io
Copy link

codecov-io commented Jan 17, 2019

Codecov Report

Merging #31 into master will increase coverage by 4.58%.
The diff coverage is 48.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #31      +/-   ##
==========================================
+ Coverage    49.1%   53.68%   +4.58%     
==========================================
  Files           8        8              
  Lines        1010     1030      +20     
==========================================
+ Hits          496      553      +57     
+ Misses        431      380      -51     
- Partials       83       97      +14
Impacted Files Coverage Δ
pkg/controller/job.go 0% <0%> (ø) ⬆️
pkg/controller/deployer.go 61.83% <0%> (+4.09%) ⬆️
pkg/controller/scheduler.go 39.81% <55%> (+17.59%) ⬆️
pkg/controller/observer.go 64% <0%> (+4%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b3c3b2...60f6b05. Read the comment docs.

@stefanprodan stefanprodan changed the title Restart validation if revision changes during analysis Restart analysis if revision changes during validation Jan 18, 2019
@stefanprodan stefanprodan merged commit 36a54fb into master Jan 18, 2019
@stefanprodan stefanprodan deleted the reset branch January 18, 2019 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants