Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Istio HTTPMatchRequest queryParams? #678

Closed
otkmnb2783 opened this issue Aug 20, 2020 · 1 comment
Closed

Support for Istio HTTPMatchRequest queryParams? #678

otkmnb2783 opened this issue Aug 20, 2020 · 1 comment

Comments

@otkmnb2783
Copy link

Hi,

Do you support the queryParams setting for Istio HTTPMatchRequest?

The queryParams in canary.yaml is not reflected in this case.

apiVersion: flagger.app/v1beta1
kind: Canary
metadata:
  name: sample
spec:
  targetRef:
    apiVersion: apps/v1
    kind: Deployment
    name:  sample
  service:
    gateways:
    - sample-gw
    hosts:
    - xxx.xxx.xxx
    trafficPolicy:
      tls:
        mode: ISTIO_MUTUAL
    match:
    - queryParams:
        version:
          exact: "v3"
      uri:
        exact: /api

  analysis:
    interval: 30s
    threshold: 5
    maxWeight: 100
    stepWeight: 25
    metrics:
    - name: request-success-rate
      threshold: 99
      interval: 30s
    - name: request-duration
      threshold: 500
      interval: 30s
@stefanprodan
Copy link
Member

Implemented in #777

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants