HTTPMatchRequest mismatch with istio's definitions

[h-r-k-matsumoto]

Problem

The following fields in Canary are not available because the definitions do not match with Istio's definitions.

field	does field exist in CRD?	does field exist in the code?
name	NO	NO
scheme	NO	YES
method	NO	YES
authority	NO	YES
headers	NO	YES
sourceLabels	NO	YES
queryParams	NO	NO
ignoreUriCase	NO	NO
withoutHeaders	NO	NO
sourceNamespace	NO	NO

In flagger, there is a definition for HTTPMatchRequest in the following.

• artifacts/flagger/crd.yaml - Only define uri.
• pkg/apis/istio/v1alpha3/virtual_service.go - Some fields do not exist.

Propose of a resolution

I would like Flaggers's definitions to match the definitions of Istio's.
I'm going to open a pull request after test is done.
main...h-r-k-matsumoto:update-istio-v1alpha3

If you have a policy that will not make any more changes to v1alpha3, Please let me know.
In that case, I don't open a pull request.

References

• https://istio.io/latest/docs/reference/config/networking/virtual-service/#HTTPMatchRequest
• https://github.com/istio/api/blob/master/networking/v1alpha3/virtual_service.pb.go
• https://github.com/istio/api/blob/1.8.1/kubernetes/customresourcedefinitions.gen.yaml#L2172
• this problem contains Support for Istio HTTPMatchRequest queryParams? #678.

[stefanprodan]

I would like Flaggers's definitions to match the definitions of Istio's.

Yes please go ahead, the API got out of sync at some point. Another problem is with authentication.istio.io/v1alpha1 that got removed but we still use it in the docs here: https://docs.flagger.app/faq#istio-mutual-tls

[h-r-k-matsumoto]

@stefanprodan Thank you for your response.
After I test tomorrow, I will open a pull request.