Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollback canary based on the deployment progress deadline check #10

Merged
merged 11 commits into from
Nov 28, 2018

Conversation

stefanprodan
Copy link
Member

@stefanprodan stefanprodan commented Nov 27, 2018

  • add ProgressDeadlineSeconds fields to Canary CRD spec
  • set progress deadline default value to 60 seconds
  • determine if the canary deployment is stuck by checking if there is a MinimumReplicasUnavailable condition and if the last update time exceeds the deadline
  • rollback canary if the progress deadline check returns a non retriable error

Fix #9

- determine if the canary deployment is stuck by checking if there is a minimum replicas unavailable condition and if the last update time exceeds the deadline
- set progress deadline default value to 60 seconds
@codecov-io
Copy link

codecov-io commented Nov 27, 2018

Codecov Report

Merging #10 into master will increase coverage by 2.44%.
The diff coverage is 38.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #10      +/-   ##
==========================================
+ Coverage      43%   45.45%   +2.44%     
==========================================
  Files           6        6              
  Lines         851      880      +29     
==========================================
+ Hits          366      400      +34     
+ Misses        435      425      -10     
- Partials       50       55       +5
Impacted Files Coverage Δ
pkg/controller/recorder.go 85.71% <100%> (+8.16%) ⬆️
pkg/controller/scheduler.go 26.82% <35.29%> (+11.34%) ⬆️
pkg/controller/deployer.go 58.09% <37.73%> (-2.09%) ⬇️
pkg/controller/controller.go 8.08% <0%> (+2.2%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8821cf...f3904ea. Read the comment docs.

@stefanprodan stefanprodan changed the title WIP: Rollback canary based on the deployment progress deadline check Rollback canary based on the deployment progress deadline check Nov 28, 2018
@stefanprodan stefanprodan merged commit 2d8adba into master Nov 28, 2018
@stefanprodan stefanprodan deleted the deadline branch November 28, 2018 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants