Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update metadata during subsequent promote #1092

Merged
merged 1 commit into from
Feb 7, 2022

Conversation

kh34
Copy link
Contributor

@kh34 kh34 commented Jan 14, 2022

Support updating primary Deployment/DaemonSet/HPA/Service labels and annotations after first-time rollout

Implements #1032, refactor of #1042 as per https://cloud-native.slack.com/archives/C01JR4YUG4B/p1635952858039600

Fix: #1032

@stefanprodan
Copy link
Member

Hi @kh34 can you please signoff your commit and properly format your commit message and PR name/description. Thanks

@codecov-commenter
Copy link

codecov-commenter commented Jan 15, 2022

Codecov Report

Merging #1092 (121eb76) into main (5776f0b) will decrease coverage by 0.00%.
The diff coverage is 46.40%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1092      +/-   ##
==========================================
- Coverage   57.29%   57.29%   -0.01%     
==========================================
  Files          78       78              
  Lines        6304     6343      +39     
==========================================
+ Hits         3612     3634      +22     
- Misses       2154     2168      +14     
- Partials      538      541       +3     
Impacted Files Coverage Δ
pkg/canary/factory.go 0.00% <0.00%> (ø)
pkg/canary/service_controller.go 0.00% <0.00%> (ø)
pkg/canary/daemonset_controller.go 59.14% <58.33%> (+0.81%) ⬆️
pkg/canary/deployment_controller.go 65.50% <64.91%> (+0.46%) ⬆️
pkg/canary/util.go 50.00% <0.00%> (+1.78%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5776f0b...121eb76. Read the comment docs.

@kh34 kh34 changed the title update Deployment/DaemonSet/HPA/Service labels and annotations during… Update metadata during subsequent promote Jan 18, 2022
@kh34
Copy link
Contributor Author

kh34 commented Jan 18, 2022

Hi @kh34 can you please signoff your commit and properly format your commit message and PR name/description. Thanks

Hi @stefanprodan I updated the PR. Thanks for reviewing.

@kh34 kh34 force-pushed the main branch 4 times, most recently from 8a13814 to 0aa9eee Compare January 18, 2022 15:19
Signed-off-by: Karl Heins <karlheins@northwesternmutual.com>

Support updating primary Deployment/DaemonSet/HPA/Service labels and annotations after first-time rollout
@stefanprodan stefanprodan added the kind/enhancement Improvement request for an existing feature label Feb 7, 2022
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @kh34 🏅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Improvement request for an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support updating primary labels/annotations after first time rollout
3 participants