-
Notifications
You must be signed in to change notification settings - Fork 741
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update metadata during subsequent promote #1092
Conversation
Hi @kh34 can you please signoff your commit and properly format your commit message and PR name/description. Thanks |
Codecov Report
@@ Coverage Diff @@
## main #1092 +/- ##
==========================================
- Coverage 57.29% 57.29% -0.01%
==========================================
Files 78 78
Lines 6304 6343 +39
==========================================
+ Hits 3612 3634 +22
- Misses 2154 2168 +14
- Partials 538 541 +3
Continue to review full report at Codecov.
|
Hi @stefanprodan I updated the PR. Thanks for reviewing. |
8a13814
to
0aa9eee
Compare
Signed-off-by: Karl Heins <karlheins@northwesternmutual.com> Support updating primary Deployment/DaemonSet/HPA/Service labels and annotations after first-time rollout
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks @kh34 🏅
Support updating primary Deployment/DaemonSet/HPA/Service labels and annotations after first-time rollout
Implements #1032, refactor of #1042 as per https://cloud-native.slack.com/archives/C01JR4YUG4B/p1635952858039600
Fix: #1032