Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set primary deployment replicas when autoscaler isn't used #1106

Merged
merged 1 commit into from
Feb 14, 2022

Conversation

somtochiama
Copy link
Member

@somtochiama somtochiama commented Feb 11, 2022

Fix: #574

This pull request sets the replica of the primary to the replica of the canary during promotion if spec.autoscalerRef isn't set in the canary custom resource.

Signed-off-by: Somtochi Onyekwere somtochionyekwere@gmail.com

docs/gitbook/faq.md Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Feb 14, 2022

Codecov Report

Merging #1106 (5b3cbd0) into main (3bfa7c9) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

❗ Current head 5b3cbd0 differs from pull request most recent head 085639b. Consider uploading reports for the commit 085639b to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1106      +/-   ##
==========================================
- Coverage   57.23%   57.21%   -0.02%     
==========================================
  Files          78       78              
  Lines        6342     6344       +2     
==========================================
  Hits         3630     3630              
- Misses       2171     2172       +1     
- Partials      541      542       +1     
Impacted Files Coverage Δ
pkg/canary/deployment_controller.go 64.38% <0.00%> (-0.45%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3bfa7c9...085639b. Read the comment docs.

Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @somtochiama 🏅

Signed-off-by: Somtochi Onyekwere <somtochionyekwere@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue when updating the number of replicas, no effect on the number of primary pods
3 participants