istio: Add destination port when port discovery and delegation are true #1145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfamador
force-pushed
the
route_port_on_delegation
branch
from
ba9dfa1
to
4311f6f
Compare
…true Signed-off-by: Marco Amador <amador.marco@gmail.com>
mfamador
force-pushed
the
route_port_on_delegation
branch
from
4311f6f
to
c7cbb72
Compare
Codecov Report
@@ Coverage Diff @@
## main #1145 +/- ##
=======================================
Coverage 56.69% 56.69%
=======================================
Files 79 79
Lines 6586 6586
=======================================
Hits 3734 3734
Misses 2297 2297
Partials 555 555
Continue to review full report at Codecov.
|
stefanprodan
added
the
kind/enhancement
stefanprodan
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we set
delegation: truein an Istio canary, and we have PortDiscovery true, since having delegation results in having no gateways the destination route gets no port.This small change makes the port to be added to the destination route when we have PortDiscovery and no gateways in the VirtualService due to having delegation.
Signed-off-by: Marco Amador amador.marco@gmail.com