Contour: Update the httproxy API and enable RetryOn #1164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrandonCate
force-pushed
the
contour-retryon-support
branch
from
095c4cd
to
2c74a8e
Compare
stefanprodan
reviewed
Apr 8, 2022
There was a problem hiding this comment.
Please copy the whole API definition from https://github.com/projectcontour/contour/blob/main/apis/projectcontour/v1/httpproxy.go so we have the latest version in Flagger's pkg/apis/projectcontour.
stefanprodan
changed the title
stefanprodan
added
the
kind/enhancement
Signed-off-by: brandoncate <brandon.cate@shipt.com>
Signed-off-by: brandoncate <brandon.cate@shipt.com>
Signed-off-by: brandoncate <brandon.cate@shipt.com>
Signed-off-by: brandoncate <brandon.cate@shipt.com>
BrandonCate
force-pushed
the
contour-retryon-support
branch
from
aff0437
to
d09969e
Compare
|
updated API def |
Codecov Report
@@ Coverage Diff @@
## main #1164 +/- ##
==========================================
+ Coverage 56.75% 56.81% +0.05%
==========================================
Files 79 79
Lines 6607 6616 +9
==========================================
+ Hits 3750 3759 +9
Misses 2301 2301
Partials 556 556
Continue to review full report at Codecov.
|
stefanprodan
approved these changes
Apr 12, 2022
|
no problem man, looking forward to helping out some more in the future |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR to add support for the retryOn field for contour's httpproxy
This will allow for a little bit more control on how the ingress is created