fix contour prom query for when service name is overwritten #1204
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
When the Canary.Spec.Service.Name field is used to override default generated name the corresponding prom queries fail to return anything during the canary analysis phase due to an incorrect envoy_cluster_name
Fix:
The envoy_cluster_name is based off of the service name and so the service name is used instead of the target name (targetRef.Name)
Note:
Unsure if this is a similar problem for all envoy based controllers