Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for KEDA ScaledObjects as an auto scaler #1216

Merged
merged 7 commits into from
Jul 8, 2022

Conversation

aryan9600
Copy link
Member

@aryan9600 aryan9600 commented Jun 9, 2022

This PR adds support for KEDA ScaledObjects to be used as an auto scaler for workloads. A new ScalerReconciler named ScaledObjectReconciler has been introduced which reconciles ScaledObjects. Users can specify a reference to their existing ScaledObject using .spec.autoscalerRef in the Canary definition.

Fixes: #1118

Sanskar Jaiswal added 2 commits June 9, 2022 21:36
Signed-off-by: Sanskar Jaiswal <sanskar.jaiswal@weave.works>
Signed-off-by: Sanskar Jaiswal <sanskar.jaiswal@weave.works>
@codecov-commenter
Copy link

codecov-commenter commented Jun 10, 2022

Codecov Report

Merging #1216 (f68f291) into main (498f065) will increase coverage by 0.01%.
The diff coverage is 61.06%.

@@            Coverage Diff             @@
##             main    #1216      +/-   ##
==========================================
+ Coverage   54.72%   54.73%   +0.01%     
==========================================
  Files          80       81       +1     
  Lines        6822     6948     +126     
==========================================
+ Hits         3733     3803      +70     
- Misses       2510     2550      +40     
- Partials      579      595      +16     
Impacted Files Coverage Δ
pkg/canary/factory.go 0.00% <0.00%> (ø)
pkg/controller/scheduler.go 45.87% <33.33%> (-0.73%) ⬇️
pkg/canary/scaled_object_reconciler.go 73.19% <73.19%> (ø)
pkg/controller/events.go 51.23% <0.00%> (-4.96%) ⬇️
pkg/router/contour.go 85.71% <0.00%> (-0.64%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 498f065...f68f291. Read the comment docs.

Signed-off-by: Sanskar Jaiswal <sanskar.jaiswal@weave.works>
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, please add tests for primaryScalerQueries.

Sanskar Jaiswal added 2 commits June 30, 2022 17:06
Signed-off-by: Sanskar Jaiswal <sanskar.jaiswal@weave.works>
Signed-off-by: Sanskar Jaiswal <sanskar.jaiswal@weave.works>
Sanskar Jaiswal added 2 commits July 1, 2022 09:43
Signed-off-by: Sanskar Jaiswal <sanskar.jaiswal@weave.works>
Signed-off-by: Sanskar Jaiswal <sanskar.jaiswal@weave.works>
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @aryan9600 🥇

@aryan9600 aryan9600 merged commit 76bac5d into fluxcd:main Jul 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Keda Support
3 participants