include Contour retryOn in the sample canary #1223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Can you please update the guide here https://github.com/fluxcd/flagger/blob/main/docs/gitbook/tutorials/contour-progressive-delivery.md#bootstrap
|
hi @stefanprodan , thanks for the quick feedback. I'm sorry to follow up but I didn't follow your ask. The section I updated is in the bootstrap section. |
|
@Mpluya in the contour-progressive-delivery.md file there are Canary examples that don't have the |
|
I checked and didnt see any other Canary examples that had the retries block within the contour-progressive-delivery.md. |
without this change the HTTPProxy - podinfo.test was not getting created due to the following warning: ``` test 4m11s Warning Synced canary/podinfo HTTPProxy podinfo.test create error: HTTPProxy.projectcontour.io "podinfo" is invalid: spec.routes.retryPolicy.retryOn: Unsupported value: "": supported values: "5xx", "gateway-error", "reset", "connect-failure", "retriable-4xx", "refused-stream", "retriable-status-codes", "retriable-headers", "cancelled", "deadline-exceeded", "internal", "resource-exhausted", "unavailable" ``` Signed-off-by: Mae Anne Large <Mpluya@users.noreply.github.com> Signed-off-by: Mae Large <mlarge@vmware.com>
Signed-off-by: Mae Large <mlarge@vmware.com>
aryan9600
approved these changes
Jul 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
without this change the HTTPProxy - podinfo.test was not getting created due to this warning:
Signed-off-by: Mae Anne Large Mpluya@users.noreply.github.com