New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(faq): Update FAQ about zero downtime with correct values #1302

Merged

stefanprodan merged 1 commit into fluxcd:main from mdolinin:fix/faq-doc-zero-downtime

Oct 27, 2022

Contributor

mdolinin commented Oct 27, 2022

Based on text and this code https://github.com/fluxcd/flagger/blob/main/pkg/canary/deployment_controller.go#L56 i think that to prevent downtime we need to set skipAnalysis: false


          fix(faq): Update FAQ about zero downtime with correct values

4d28b90

Signed-off-by: mdolinin <dmo.builder@gmail.com>

mdolinin requested a review from stefanprodan as a code owner

October 27, 2022 00:59

stefanprodan approved these changes

View reviewed changes

Member

stefanprodan left a comment

LGTM

Thanks @mdolinin

stefanprodan added the kind/docs label

stefanprodan merged commit 52dd8f8 into fluxcd:main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels