Allow access to Prometheus in OpenShift via SA token #1338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aryan9600
requested changes
Jan 17, 2023
Codecov ReportBase: 54.24% // Head: 54.27% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1338 +/- ##
==========================================
+ Coverage 54.24% 54.27% +0.02%
==========================================
Files 84 84
Lines 10016 10022 +6
==========================================
+ Hits 5433 5439 +6
Misses 3927 3927
Partials 656 656
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
@wwadge Could you please squash all commits into one? |
wwadge
force-pushed
the
add-prometheus-bearer-auth
branch
from
f280f27
to
1b17b5d
Compare
Done |
aryan9600
requested changes
Jan 18, 2023
Fixes: fluxcd#1064 Signed-off-by: Wallace Wadge <wwadge@gmail.com>
wwadge
force-pushed
the
add-prometheus-bearer-auth
branch
from
62fa012
to
a50d7de
Compare
aryan9600
approved these changes
Jan 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1064
We can already access prometheus using Basic Auth. This PR adds support to access prometheus using Authorization: Bearer token too.
Signed-off-by: Wallace Wadge wwadge@gmail.com