Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Istio FaultInjection #1643

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

S-mishina
Copy link
Contributor

summary

Support Istio FaultInjection supported.

reference)
#1548

Signed-off-by: S-mishina <seiryu.mishina@zozo.com>
@S-mishina S-mishina marked this pull request as ready for review May 15, 2024 14:22
@S-mishina S-mishina requested a review from stefanprodan as a code owner May 15, 2024 14:22
@S-mishina
Copy link
Contributor Author

build / build-flagger (pull_request)

Investigating the reason for the error.

@S-mishina S-mishina marked this pull request as draft May 15, 2024 14:33
S-mishina added 2 commits May 15, 2024 23:44
Signed-off-by: S-mishina <seiryu.mishina@zozo.com>
Signed-off-by: S-mishina <seiryu.mishina@zozo.com>
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 20.68966% with 23 lines in your changes are missing coverage. Please review.

Project coverage is 34.08%. Comparing base (e3a529e) to head (9e86729).
Report is 18 commits behind head on main.

Files Patch % Lines
pkg/apis/istio/v1beta1/zz_generated.deepcopy.go 0.00% 19 Missing ⚠️
pkg/apis/flagger/v1beta1/zz_generated.deepcopy.go 0.00% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1643       +/-   ##
===========================================
- Coverage   56.51%   34.08%   -22.43%     
===========================================
  Files          85      282      +197     
  Lines        8571    20584    +12013     
===========================================
+ Hits         4844     7017     +2173     
- Misses       3053    12636     +9583     
- Partials      674      931      +257     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@S-mishina S-mishina marked this pull request as ready for review May 15, 2024 15:15
@S-mishina
Copy link
Contributor Author

@stefanprodan @aryan9600

Hello
What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants