-
Notifications
You must be signed in to change notification settings - Fork 740
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Custom BackendRef for Primary and Canary Services #1736
Conversation
9844afe
to
ac3b97b
Compare
This is never the case for Flagger Canaries, the Kubernetes Services and the HTTPRoutes are always in the same namespace, next to the Kubernetes Deployment. |
ac3b97b
to
c8b3184
Compare
Signed-off-by: kahirokunn <okinakahiro@gmail.com>
Signed-off-by: kahirokunn <okinakahiro@gmail.com>
…way API support Signed-off-by: kahirokunn <okinakahiro@gmail.com>
c8b3184
to
092d4f9
Compare
@stefanprodan I have updated the PR to introduce Custom BackendRef for Primary and Canary Services. This enhancement allows referencing services in different namespaces, and as a result, ReferenceGrants are now automatically created. With these changes, Flagger's Gateway API integration is significantly strengthened, enabling support for numerous use cases such as:
I believe these improvements will greatly enhance the flexibility and integration capabilities of Flagger. I appreciate your look forward to your continued feedback. Best regards, |
We can't allow this in a Flagger canary, the Kubernetes Services managed by Flagger are always in the same namespace as the HTTPRoutes. |
@stefanprodan To clarify my intention: This PR aims to enable HTTPRoute's backendRefs to point to Kubernetes Services that are not managed by Flagger, while keeping Flagger-managed services within the same namespace as the HTTPRoutes. The current implementation in the PR (03acf7a) is still a work in progress, but the goal is to provide more flexibility in routing configurations while maintaining Flagger's core functionality and namespace constraints. I'm happy to adjust the implementation based on your guidance. Best regards, |
move to #1742 |
Description
This PR adds support for custom backend references in Flagger's primary and canary services. This enhancement allows users to specify different routing configurations and intermediate services for primary and canary traffic, enabling more complex deployment patterns and better integration with existing infrastructure.
Key Changes
BackendRef
fieldUse Cases
This feature enables several important scenarios:
Example Configuration
Breaking Changes
None. This is a backward-compatible change that maintains existing behavior when custom backend references are not specified.
Issue
#1741