Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix promoting canary when max weight is not a multiple of step #190

Merged
merged 1 commit into from
May 23, 2019
Merged

Fix promoting canary when max weight is not a multiple of step #190

merged 1 commit into from
May 23, 2019

Conversation

olga-mir
Copy link
Contributor

In canary scenario, if maxWeight is not exact multiple of stepWeight then during canary promotion flow the new spec will not be copied to primary. The canary will be reported successful, but the app version will be the old one.

This solves #189

Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @olga-mir

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants