Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Kubernetes 1.11 CRD status sub-resource #29

Merged
merged 8 commits into from
Jan 17, 2019
Merged

Use Kubernetes 1.11 CRD status sub-resource #29

merged 8 commits into from
Jan 17, 2019

Conversation

stefanprodan
Copy link
Member

@stefanprodan stefanprodan commented Jan 16, 2019

  • drop compatibility with Kubernetes 1.10
  • add status and additional printer columns to Canary CRD
  • use CRD UpdateStatus for Canary status updates
  • skip readiness checks if the canary analysis is not running
  • rename status state to phase (Initialized, Progressing, Succeeded, Failed)
  • add canary weight to status

Canary status:

kubectl describe canary

Status:
  Canary Weight:         15
  Failed Checks:         5
  Last Applied Spec:     eyJjb250YWluZXJz.....
  Last Transition Time:  2019-01-16T13:47:16Z
  Phase:                 Progressing

Additional printer columns:

kubectl get canaries --all-namespaces

NAMESPACE   NAME      STATUS        WEIGHT   LASTTRANSITIONTIME
test        podinfo   Progressing   15       2019-01-16T14:05:07Z
prod        frontend  Succeeded     0        2019-01-15T16:15:07Z
prod        backend   Failed        0        2019-01-14T17:05:07Z

Fix #11

@codecov-io
Copy link

codecov-io commented Jan 16, 2019

Codecov Report

Merging #29 into master will decrease coverage by 0.53%.
The diff coverage is 57.37%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #29      +/-   ##
=========================================
- Coverage   49.64%   49.1%   -0.54%     
=========================================
  Files           8       8              
  Lines         987    1010      +23     
=========================================
+ Hits          490     496       +6     
- Misses        416     431      +15     
- Partials       81      83       +2
Impacted Files Coverage Δ
pkg/controller/router.go 86.15% <100%> (+0.07%) ⬆️
pkg/controller/recorder.go 81.63% <100%> (ø) ⬆️
pkg/controller/scheduler.go 22.22% <15.78%> (-0.82%) ⬇️
pkg/controller/controller.go 6.91% <66.66%> (ø) ⬆️
pkg/controller/deployer.go 57.73% <70%> (-1.47%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1b84cd...1d31b5e. Read the comment docs.

- add status phases (Initialized, Progressing, Succeeded, Failed)
- rename status revision to LastAppliedSpec
- show current weight on kubectl get canaries and kubectl get all
- zap key-value: canary=name.namespace
@stefanprodan stefanprodan merged commit 1b3c3b2 into master Jan 17, 2019
@stefanprodan stefanprodan deleted the status branch January 17, 2019 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants