Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow setting Slack and Teams URLs with env vars #334

Merged
merged 2 commits into from
Oct 10, 2019
Merged

Allow setting Slack and Teams URLs with env vars #334

merged 2 commits into from
Oct 10, 2019

Conversation

stefanprodan
Copy link
Member

  • overwrite Slack and Teams command args with SLACK_URL and MSTEAMS_URL env variables
  • add env to Helm chart options to be used for Slack and Teams URLs

Fix: #332

@stefanprodan stefanprodan merged commit 780f3d2 into master Oct 10, 2019
@stefanprodan stefanprodan deleted the env-vars branch October 10, 2019 06:05
@stefanprodan stefanprodan mentioned this pull request Oct 21, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcherman dcherman dcherman left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Secret and Env support
2 participants
@stefanprodan @dcherman