Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement App Mesh HTTP retry policy #338

Merged
merged 3 commits into from
Oct 15, 2019
Merged

Implement App Mesh HTTP retry policy #338

merged 3 commits into from
Oct 15, 2019

Conversation

stefanprodan
Copy link
Member

@stefanprodan stefanprodan commented Oct 14, 2019

This PR implements retry policies for App Mesh fix #303

Example:

apiVersion: flagger.app/v1alpha3
kind: Canary
metadata:
  name: podinfo
spec:
  service:
    port: 9898
    meshName: global
    # App Mesh retry policy (optional)
    retries:
      attempts: 3
      perTryTimeout: 1s
      retryOn: "gateway-error,client-error,stream-error"

Based on the above spec Flagger will create a Virtual service route like:

    routes:
    - http:
        action:
          weightedTargets:
          - virtualNodeName: podinfo-canary
            weight: 0
          - virtualNodeName: podinfo-primary
            weight: 100
        match:
          prefix: /
        retryPolicy:
          httpRetryEvents:
          - gateway-error
          - client-error
          - stream-error
          maxRetries: 3
          perRetryTimeoutMillis: 1000

Tested on EKS 1.14 with App Mesh controller v0.1.2

@stefanprodan stefanprodan merged commit 8345fea into master Oct 15, 2019
@stefanprodan stefanprodan deleted the appmesh-up branch October 15, 2019 05:45
@stefanprodan stefanprodan mentioned this pull request Oct 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

App Mesh retry policy
1 participant