Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track changes in ConfigMaps and Secrets #37

Merged
merged 13 commits into from
Jan 30, 2019
Merged

Track changes in ConfigMaps and Secrets #37

merged 13 commits into from
Jan 30, 2019

Conversation

stefanprodan
Copy link
Member

@stefanprodan stefanprodan commented Jan 25, 2019

This PR adds support for tracking ConfigMaps and Secrets referenced by a canary deployment:

  • scan target deployment volumes and containers for configs and secrets
  • create primary configs and secrets at bootstrap
  • detect changes in configs or secrets and trigger a new canary rollout
  • restart analysis if configs or secrets changed during rollout
  • copy configs from canary to primary and update the pod spec annotations on promotion

Fix: #36

- scan target deployment volumes and containers for configmaps and secrets
- create primary configs and secrets at bootstrap
- copy configs and secrets from canary to primary and update the pod spec on promotion
@codecov-io
Copy link

codecov-io commented Jan 25, 2019

Codecov Report

Merging #37 into master will increase coverage by 3.23%.
The diff coverage is 69.39%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #37      +/-   ##
==========================================
+ Coverage   53.52%   56.75%   +3.23%     
==========================================
  Files           8        9       +1     
  Lines        1035     1302     +267     
==========================================
+ Hits          554      739     +185     
- Misses        384      436      +52     
- Partials       97      127      +30
Impacted Files Coverage Δ
pkg/controller/controller.go 6.7% <0%> (-0.22%) ⬇️
pkg/controller/deployer.go 59.28% <51.92%> (-2.55%) ⬇️
pkg/controller/scheduler.go 39.73% <54.54%> (+0.62%) ⬆️
pkg/controller/tracker.go 76.05% <76.05%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8a7ea8...4bcf82d. Read the comment docs.

@stefanprodan stefanprodan changed the title Track ConfigMaps and Secrets Track changes in ConfigMaps and Secrets Jan 26, 2019
@stefanprodan stefanprodan merged commit 737507b into master Jan 30, 2019
@stefanprodan stefanprodan deleted the track-configs branch January 30, 2019 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants