support gated rollback #420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If this approach proves acceptable, I will add updated to the docs as well |
|
@ta924 this looks good, thanks! The hook type needs to be added to the CRD validation in artifacts, chart and kustomize. Looking forward to the docs updates. |
|
@stefanprodan thanks for the additional details, I have updated the CRD validations and started dropping in some verbiage around rollbacks. Should have that finalized today or tomorrow |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for gated rollbacks. I would like to propose this as an option to enable rollbacks based off webhooks when doing manual gating. During the reconciliation loop the controller would evaluate the status of the canary under review, if that status was in either waiting or progressing and a rollback webhook returned a 200 response it would trigger the rollback functionality.
Changes:
add RollbackHook HookType
codegen for client libraries to included HookType addition
move rollback functionality of the scheduler into method for re-use with failure scenarios and manual rollback
introduce runRollbackHooks method
Fix: #413