Add support for Istio multi-cluster #447
Conversation
Body:- If applied this commit will resolve the following reported issue fluxcd#437 Have added support for consuming kubeconfig of istio host cluster where istio resources will be created.
stefanprodan
changed the title
|
@viditganpi can you please describe how was this tested? Which of the multi-cluster setups have you used https://istio.io/docs/setup/install/multicluster/? |
I have used this setup -> https://istio.io/docs/setup/install/multicluster/shared-vpn/ |
|
Ok so for this to work, Flagger Helm chart should have a |
and service kubeconfig 2. Modified deployment to pass and mount secrets for configs.
done that |
cmd/flagger/main.go
Outdated
| @@ -111,20 +113,26 @@ func main() { | |||
| if err != nil { | |||
| logger.Fatalf("Error building kubeconfig: %v", err) | |||
| } | |||
|
|
|||
| fmt.Println(cfg) | |||
| - -kubeconfig=/tmp/istio-source/config1 | ||
| {{- end }} | ||
| {{- if .Values.kubeconfigHost }} | ||
| - -kubeconfig-host=/tmp/istio-host/config1 |
There was a problem hiding this comment.
Replace config1 with kubeconfig
| @@ -90,6 +110,12 @@ spec: | |||
| {{- if .Values.eventWebhook }} | |||
| - -event-webhook={{ .Values.eventWebhook }} | |||
| {{- end }} | |||
| {{- if .Values.kubeconfigSource }} | |||
| - -kubeconfig=/tmp/istio-source/config1 | |||
There was a problem hiding this comment.
Replace config1 with kubeconfig
|
CI is failing because the code is not properly formatted, please run |
|
You've pushed a binary file called |
To test I created a secret from host cluster kubeconfig and mounted it with flagger deployment in service cluster. |
Body:-
If applied this commit will resolve the following reported issue #437
Have added support for consuming kubeconfig of istio host cluster where istio
resources will be created.