Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkg/controller: Refactor scheduler #484

Merged
merged 1 commit into from
Mar 9, 2020
Merged

pkg/controller: Refactor scheduler #484

merged 1 commit into from
Mar 9, 2020

Conversation

stefanprodan
Copy link
Member

@stefanprodan stefanprodan commented Mar 9, 2020 •
edited
Loading

  • move scheduler metrics and hooks to dedicated files
  • remove weight params from shouldSkipAnalysis

@stefanprodan
pkg/controller: Refactor scheduler
d35290d 
- move scheduler metrics and hooks to dedicate files
- remove weight params from shouldSkipAnalysis
mathetake
mathetake approved these changes Mar 9, 2020
View reviewed changes
Copy link
Collaborator

@mathetake mathetake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stefanprodan stefanprodan merged commit 714dd86 into master Mar 9, 2020
@stefanprodan stefanprodan deleted the scheduler-refactoring branch March 9, 2020 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mathetake mathetake mathetake approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stefanprodan @mathetake