Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the logLevel configuration in helm charts #506

Merged
merged 3 commits into from
Mar 17, 2020
Merged

Add the logLevel configuration in helm charts #506

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3aa3ae2
Add the logLevel configuration in helm charts
sayboras Mar 17, 2020
b023701
Revert chart version upgrade
sayboras Mar 17, 2020
f2ef833
Update README.md
sayboras Mar 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/flagger/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
apiVersion: v1
name: flagger
version: 0.24.0
version: 0.25.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please undo this change, the version bump is part of the release procedure.

appVersion: 1.0.0-rc.1
kubeVersion: ">=1.11.0-0"
engine: gotpl
Expand Down
4 changes: 4 additions & 0 deletions charts/flagger/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,11 @@ spec:
containerPort: 8080
command:
- ./flagger
{{- if .Values.logLevel }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no need for an if/else here since the default value is info.

- -log-level={{ .Values.logLevel }}
{{- else }}
- -log-level=info
{{- end }}
{{- if .Values.meshProvider }}
- -mesh-provider={{ .Values.meshProvider }}
{{- end }}
Expand Down
3 changes: 3 additions & 0 deletions charts/flagger/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,9 @@ image:
pullPolicy: IfNotPresent
pullSecret:

# accepted values are debug, info, warning, error (defaults to info)
logLevel: "info"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the double quotes.


podAnnotations:
prometheus.io/scrape: "true"
prometheus.io/port: "8080"
Expand Down