Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

e2e: Upgrade nginx helm chart to 1.34.2 #511

Merged
merged 3 commits into from
Mar 19, 2020
Merged

e2e: Upgrade nginx helm chart to 1.34.2 #511

merged 3 commits into from
Mar 19, 2020

Conversation

sayboras
Copy link
Contributor

@sayboras sayboras commented Mar 19, 2020 •
edited
Loading

Upgrade nginx chart to 1.34.2
Remove obsolete stats configuration as per https://github.com/helm/charts/pull/16139/files

@sayboras sayboras changed the title Upgrade nginx help to 1.34.2 Upgrade nginx helm to 1.34.2 Mar 19, 2020
@sayboras sayboras marked this pull request as ready for review March 19, 2020 10:09
stefanprodan
stefanprodan approved these changes Mar 19, 2020
View reviewed changes
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @sayboras

@stefanprodan stefanprodan changed the title Upgrade nginx helm to 1.34.2 e2e: Upgrade nginx helm chart to 1.34.2 Mar 19, 2020
@stefanprodan stefanprodan merged commit b146163 into fluxcd:master Mar 19, 2020
@sayboras sayboras deleted the debug/nginx-metrics branch March 19, 2020 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefanprodan stefanprodan stefanprodan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sayboras @stefanprodan