Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chart: Add annotations for service account #521

Merged

Conversation

sayboras
Copy link
Contributor

@sayboras sayboras commented Mar 25, 2020

In order to use AWS EKS IAM Roles for Service Accounts feature, one must annotate the service account to specify what IAM role admin wants to grant to that service account.

apiVersion: v1
kind: ServiceAccount
metadata:
  annotations:
    eks.amazonaws.com/role-arn: arn:aws:iam::AWS_ACCOUNT_ID:role/IAM_ROLE_NAME

@codecov-io
Copy link

codecov-io commented Mar 25, 2020

Codecov Report

Merging #521 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #521   +/-   ##
=======================================
  Coverage   50.29%   50.29%           
=======================================
  Files          63       63           
  Lines        4939     4939           
=======================================
  Hits         2484     2484           
  Misses       2044     2044           
  Partials      411      411           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 423424c...99366b4. Read the comment docs.

Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stefanprodan stefanprodan changed the title Add annotations for service account chart: Add annotations for service account Mar 25, 2020
@stefanprodan stefanprodan merged commit 658dec2 into fluxcd:master Mar 25, 2020
@sayboras sayboras deleted the feature/service-accounts-annotations branch March 25, 2020 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants