Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add prometheus-operator tutorial #524

Merged
merged 4 commits into from
Mar 27, 2020

Conversation

Wihrt
Copy link

@Wihrt Wihrt commented Mar 26, 2020

Add documentation for flagger with prometheus-operator

@codecov-io
Copy link

Codecov Report

Merging #524 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #524   +/-   ##
=======================================
  Coverage   50.29%   50.29%           
=======================================
  Files          63       63           
  Lines        4939     4939           
=======================================
  Hits         2484     2484           
  Misses       2044     2044           
  Partials      411      411           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 658dec2...2b1aacc. Read the comment docs.

@stefanprodan
Copy link
Member

@Wihrt is this PR ready for review? I see NGINX references and the last sentence doesn't look finished.

iterations: 10
threshold: 2
metrics:
# For some reason, you need to not use a standard name
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reason is that the standard names are reserved for the builtin metrics, please change this.

provider:
address: http://prometheus-prometheus-oper-prometheus.prometheus:9090
type: prometheus
query: rate(http_requests_total{namespace="{{ namespace }}",job="{{ target }}-canary",status!~"5.*"}[{{ interval }}]) / rate(http_requests_total{namespace="{{ namespace }}",job="{{ target }}-canary"}[{{ interval }}]) * 100
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please format this so it's readable, there are many examples in the docs if you want to see how it should look.

helm repo add stable https://kubernetes-charts.storage.googleapis.com
helm repo update
kubectl create ns prometheus
helm upgrade -i prometheus stable/prometheus-operator \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use fullnameOverride and set the namespace to monitoring so that the URL will look better.

Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @Wihrt I'll include the tutorial in the docs site on the next Flagger release

@stefanprodan stefanprodan changed the title Add documentation for prometheus-operator docs: Add prometheus-operator tutorial Mar 27, 2020
@stefanprodan stefanprodan merged commit 9c46be1 into fluxcd:master Mar 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants