Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkg/router: update ingress API to networking.k8s.io/v1beta1 #534

Merged
merged 4 commits into from
Mar 30, 2020
Merged

pkg/router: update ingress API to networking.k8s.io/v1beta1 #534

merged 4 commits into from
Mar 30, 2020

Conversation

stefanprodan
Copy link
Member

Changes:

  • use networking.k8s.io/v1beta1 in ingress router
  • update unit tests, end-to-end tests and docs to networking.k8s.io/v1beta1

Breaking change: drop compatibility with Kubernetes 1.13.

Fix: #533

@codecov-io
Copy link

codecov-io commented Mar 29, 2020 •
edited
Loading

Codecov Report

Merging #534 into master will not change coverage by %.
The diff coverage is 85.71%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #534   +/-   ##
=======================================
  Coverage   50.69%   50.69%           
=======================================
  Files          63       63           
  Lines        4902     4902           
=======================================
  Hits         2485     2485           
  Misses       2005     2005           
  Partials      412      412
Impacted Files Coverage Δ
pkg/router/ingress.go 53.54% <85.71%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 388ad04...6d2c172. Read the comment docs.

@stefanprodan stefanprodan changed the title Update ingress API to networking.k8s.io/v1beta1 pkg/router: Update ingress API to networking.k8s.io/v1beta1 Mar 30, 2020
@stefanprodan stefanprodan changed the title pkg/router: Update ingress API to networking.k8s.io/v1beta1 pkg/router: update ingress API to networking.k8s.io/v1beta1 Mar 30, 2020
mathetake
mathetake approved these changes Mar 30, 2020
View reviewed changes
Copy link
Collaborator

@mathetake mathetake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

thanks @stefanprodan !

@stefanprodan stefanprodan merged commit ccc17b0 into master Mar 30, 2020
@stefanprodan stefanprodan deleted the ingress-update branch March 30, 2020 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mathetake mathetake mathetake approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Ingress to networking.k8s.io/v1beta1
3 participants
@stefanprodan @codecov-io @mathetake