Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add HTTP match and rewrite to Canary service spec #55

Merged
merged 5 commits into from
Feb 25, 2019
Merged

Add HTTP match and rewrite to Canary service spec #55

merged 5 commits into from
Feb 25, 2019

Conversation

stefanprodan
Copy link
Member

@stefanprodan stefanprodan commented Feb 24, 2019 •
edited
Loading

Add Istio HTTPMatchRequest and HTTPRewrite to Canary CRD.

apiVersion: flagger.app/v1alpha3
kind: Canary
metadata:
  name: podinfo
spec:
  service:
    port: 9898
    match:
      - uri:
          prefix: /podinfo/
    rewrite:
      uri: /
.........

Test image: quay.io/stefanprodan/flagger:http-match-eabef3d

Fix: #50

@codecov-io
Copy link

codecov-io commented Feb 24, 2019 •
edited
Loading

Codecov Report

Merging #55 into master will increase coverage by 0.19%.
The diff coverage is 93.1%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #55      +/-   ##
==========================================
+ Coverage   56.69%   56.88%   +0.19%     
==========================================
  Files           9        9              
  Lines        1344     1350       +6     
==========================================
+ Hits          762      768       +6     
  Misses        448      448              
  Partials      134      134
Impacted Files Coverage Δ
pkg/controller/router.go 85.37% <93.1%> (+0.42%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c835892...eabef3d. Read the comment docs.

@stefanprodan
Add HTTP match and rewrite docs
6750f10
@stefanprodan
Router improvements
eabef3d 
- change virtual service route to canary service
- keep the existing destination weights on virtual service updates
- set the match conditions and URI rewrite when changing the traffic weight
@stefanprodan stefanprodan merged commit 94dcd6c into master Feb 25, 2019
@stefanprodan stefanprodan deleted the http-match branch February 25, 2019 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add HTTP match conditions to Canary service spec
2 participants
@stefanprodan @codecov-io