Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement AppMesh v1beta2 router #584

Merged
merged 13 commits into from
May 14, 2020
Merged

Implement AppMesh v1beta2 router #584

merged 13 commits into from
May 14, 2020

Conversation

stefanprodan
Copy link
Member

@stefanprodan stefanprodan commented May 13, 2020

This PR adds support for AppMesh v1beta2. Since v1beta2 is not backwards compatible, users must set the provider to appmesh:v1beta2 on new cluster in order to use Flagger with the new AppMesh manager.

Changes:

  • add AppMesh v1beta2 router (provider appmesh:v1beta2)
  • maintain compatibility with AppMesh v1beta1 (provider appmesh)
  • register VirtualNodes before primary deployment initialisation
  • add provider list to API
  • refactor observer factory
  • add Envoy metric templates to crossover docs
  • fix service annotation diff

TODO (followup PRs):

  • add v1beta2 VirtualNodes to loadtester helm chart
  • rewrite the Flagger AppMesh Gateway for v1beta2
  • create docs for AppMesh v1beta2 setup on EKS
  • rewrite AppMesh tutorial when v1beta2 is released by AWS

Ref: #577

@codecov-io
Copy link

codecov-io commented May 13, 2020

Codecov Report

Merging #584 into master will increase coverage by 2.36%.
The diff coverage is 75.12%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #584      +/-   ##
==========================================
+ Coverage   52.72%   55.08%   +2.36%     
==========================================
  Files          63       62       -1     
  Lines        4922     5221     +299     
==========================================
+ Hits         2595     2876     +281     
- Misses       1924     1928       +4     
- Partials      403      417      +14     
Impacted Files Coverage Δ
pkg/controller/finalizer.go 39.75% <0.00%> (ø)
pkg/metrics/observers/factory.go 0.00% <0.00%> (ø)
pkg/router/factory.go 0.00% <0.00%> (ø)
pkg/controller/scheduler.go 46.88% <22.22%> (-0.33%) ⬇️
pkg/router/kubernetes_default.go 64.82% <50.00%> (-0.91%) ⬇️
pkg/router/appmesh_v1beta2.go 86.88% <86.88%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6f3a24...6498ccc. Read the comment docs.

AppMesh does not support port mappings
@stefanprodan stefanprodan merged commit 474a5a2 into master May 14, 2020
@stefanprodan stefanprodan deleted the appmesh-v1beta2 branch May 14, 2020 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants